fix: Log on error by default in async workflow executions (#8723)
This commit is contained in:
@@ -165,6 +165,7 @@ export class InMemoryDistributedTransactionStorage
|
||||
const inter = setTimeout(async () => {
|
||||
await this.workflowOrchestratorService_.run(workflowId, {
|
||||
transactionId,
|
||||
logOnError: true,
|
||||
throwOnError: false,
|
||||
})
|
||||
}, interval * 1e3)
|
||||
@@ -322,6 +323,7 @@ export class InMemoryDistributedTransactionStorage
|
||||
try {
|
||||
// With running the job after setting a new timer we basically allow for concurrent runs, unless we add idempotency keys once they are supported.
|
||||
await this.workflowOrchestratorService_.run(jobId, {
|
||||
logOnError: true,
|
||||
throwOnError: false,
|
||||
})
|
||||
} catch (e) {
|
||||
|
||||
@@ -125,6 +125,7 @@ export class RedisDistributedTransactionStorage
|
||||
private async executeTransaction(workflowId: string, transactionId: string) {
|
||||
return await this.workflowOrchestratorService_.run(workflowId, {
|
||||
transactionId,
|
||||
logOnError: true,
|
||||
throwOnError: false,
|
||||
})
|
||||
}
|
||||
@@ -137,6 +138,7 @@ export class RedisDistributedTransactionStorage
|
||||
// TODO: In the case of concurrency being forbidden, we want to generate a predictable transaction ID and rely on the idempotency
|
||||
// of the transaction to ensure that the transaction is only executed once.
|
||||
return await this.workflowOrchestratorService_.run(jobId, {
|
||||
logOnError: true,
|
||||
throwOnError: false,
|
||||
})
|
||||
} catch (e) {
|
||||
|
||||
Reference in New Issue
Block a user