asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(dashboard): tax region override too large payload (#13860)

Browse Source 
* Limit the number of ids passed to the different queries to render the tooltip details to 10, for products, product types and shipping options

* Add changeset

* Extract common additional field computation into variable
This commit is contained in:
Nicolas Gorga
2025-10-27 11:48:34 -03:00
committed by GitHub
parent ef798160ea
commit 9f154c308e
2 changed files with 19 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/breezy-walls-film.md Normal file
View File

@@ -0,0 +1,5 @@
---
"@medusajs/dashboard": patch
---
fix(dashboard): Limit number of ids passed in tax region override queries to avoid PayloadTooLargeError

33
packages/admin/dashboard/src/routes/tax-regions/common/components/tax-override-card/tax-override-card.tsx
View File

@@ -25,6 +25,7 @@ import { formatPercentage } from "../../../../../lib/percentage-helpers"
import { TaxRateRuleReferenceType } from "../../constants"
import { useDeleteTaxRateAction } from "../../hooks"
import { useShippingOptions } from "../../../../../hooks/api"
import { DISPLAY_OVERRIDE_ITEMS_LIMIT } from "../../../tax-region-tax-override-edit/components/tax-region-tax-override-edit-form"
interface TaxOverrideCardProps extends ComponentPropsWithoutRef<"div"> {
taxRate: HttpTypes.AdminTaxRate
@@ -279,8 +280,8 @@ const useReferenceValues = (
} => {
const products = useProducts(
{
id: ids,
limit: 10,
id: ids.slice(0, DISPLAY_OVERRIDE_ITEMS_LIMIT),
limit: DISPLAY_OVERRIDE_ITEMS_LIMIT,
},
{
enabled: !!ids.length && type === TaxRateRuleReferenceType.PRODUCT,
@@ -299,8 +300,8 @@ const useReferenceValues = (
const productTypes = useProductTypes(
{
id: ids,
limit: 10,
id: ids.slice(0, DISPLAY_OVERRIDE_ITEMS_LIMIT),
limit: DISPLAY_OVERRIDE_ITEMS_LIMIT,
},
{
enabled: !!ids.length && type === TaxRateRuleReferenceType.PRODUCT_TYPE,
@@ -309,8 +310,8 @@ const useReferenceValues = (
const shippingOptions = useShippingOptions(
{
id: ids,
limit: 10,
id: ids.slice(0, DISPLAY_OVERRIDE_ITEMS_LIMIT),
limit: DISPLAY_OVERRIDE_ITEMS_LIMIT,
},
{
enabled:
@@ -337,16 +338,16 @@ const useReferenceValues = (
// enabled: !!ids.length && type === TaxRateRuleReferenceType.CUSTOMER_GROUP,
// }
// )
const additionalCount =
ids.length > DISPLAY_OVERRIDE_ITEMS_LIMIT
? ids.length - DISPLAY_OVERRIDE_ITEMS_LIMIT
: 0
switch (type) {
case TaxRateRuleReferenceType.PRODUCT:
return {
labels: products.products?.map((product) => product.title),
isPending: products.isPending,
additional:
products.products && products.count
? products.count - products.products.length
: 0,
additional: additionalCount,
isError: products.isError,
error: products.error,
}
@@ -365,10 +366,7 @@ const useReferenceValues = (
return {
labels: productTypes.product_types?.map((type) => type.value),
isPending: productTypes.isPending,
additional:
productTypes.product_types && productTypes.count
? productTypes.count - productTypes.product_types.length
: 0,
additional: additionalCount,
isError: productTypes.isError,
error: productTypes.error,
}
@@ -376,10 +374,7 @@ const useReferenceValues = (
return {
labels: shippingOptions.shipping_options?.map((option) => option.name),
isPending: shippingOptions.isPending,
additional: shippingOptions.count
? shippingOptions.count -
(shippingOptions.shipping_options?.length || 0)
: 0,
additional: additionalCount,
isError: shippingOptions.isError,
error: shippingOptions.error,
}