fix(types,order): fixes to order module's service and data models (#8247)

* fix(types,order): fixes to order module's service and data models

* revert change for createLineItemAdjustments

* add missing context parameter

packages/core/types/src/order/service.ts

@@ -280,7 +280,10 @@ export interface IOrderModuleService extends IModuleService {
    * ```
    *
    */
-  updateOrders(data: UpdateOrderDTO[]): Promise<OrderDTO[]>
+  updateOrders(
+    data: UpdateOrderDTO[],
+    sharedContext?: Context
+  ): Promise<OrderDTO[]>
 
   /**
    * This method updates existing {return type}(s).
@@ -561,8 +564,14 @@ export interface IOrderModuleService extends IModuleService {
     sharedContext?: Context
   ): Promise<OrderLineItemDTO[]>
 
-  createLineItems(data: CreateOrderLineItemDTO): Promise<OrderLineItemDTO[]>
-  createLineItems(data: CreateOrderLineItemDTO[]): Promise<OrderLineItemDTO[]>
+  createLineItems(
+    data: CreateOrderLineItemDTO,
+    sharedContext?: Context
+  ): Promise<OrderLineItemDTO[]>
+  createLineItems(
+    data: CreateOrderLineItemDTO[],
+    sharedContext?: Context
+  ): Promise<OrderLineItemDTO[]>
   createLineItems(
     orderId: string,
     items: CreateOrderLineItemDTO[],
@@ -595,7 +604,8 @@ export interface IOrderModuleService extends IModuleService {
    *
    */
   updateLineItems(
-    data: UpdateOrderLineItemWithSelectorDTO[]
+    data: UpdateOrderLineItemWithSelectorDTO[],
+    sharedContext?: Context
   ): Promise<OrderLineItemDTO[]>
 
   /**
@@ -756,10 +766,12 @@ export interface IOrderModuleService extends IModuleService {
   ): Promise<OrderShippingMethodDTO[]>
 
   createShippingMethods(
-    data: CreateOrderShippingMethodDTO
+    data: CreateOrderShippingMethodDTO,
+    sharedContext?: Context
   ): Promise<OrderShippingMethodDTO>
   createShippingMethods(
-    data: CreateOrderShippingMethodDTO[]
+    data: CreateOrderShippingMethodDTO[],
+    sharedContext?: Context
   ): Promise<OrderShippingMethodDTO[]>
   createShippingMethods(
     orderId: string,
@@ -812,14 +824,17 @@ export interface IOrderModuleService extends IModuleService {
   ): Promise<OrderLineItemAdjustmentDTO[]>
 
   createLineItemAdjustments(
-    data: CreateOrderAdjustmentDTO[]
+    data: CreateOrderAdjustmentDTO[],
+    sharedContext?: Context
   ): Promise<OrderLineItemAdjustmentDTO[]>
   createLineItemAdjustments(
-    data: CreateOrderAdjustmentDTO
+    data: CreateOrderAdjustmentDTO,
+    sharedContext?: Context
   ): Promise<OrderLineItemAdjustmentDTO[]>
   createLineItemAdjustments(
     orderId: string,
-    data: CreateOrderAdjustmentDTO[]
+    data: CreateOrderAdjustmentDTO[],
+    sharedContext?: Context
   ): Promise<OrderLineItemAdjustmentDTO[]>
 
   /**
@@ -884,10 +899,12 @@ export interface IOrderModuleService extends IModuleService {
   ): Promise<OrderShippingMethodAdjustmentDTO[]>
 
   createShippingMethodAdjustments(
-    data: CreateOrderShippingMethodAdjustmentDTO[]
+    data: CreateOrderShippingMethodAdjustmentDTO[],
+    sharedContext?: Context
   ): Promise<OrderShippingMethodAdjustmentDTO[]>
   createShippingMethodAdjustments(
-    data: CreateOrderShippingMethodAdjustmentDTO
+    data: CreateOrderShippingMethodAdjustmentDTO,
+    sharedContext?: Context
   ): Promise<OrderShippingMethodAdjustmentDTO>
   createShippingMethodAdjustments(
     orderId: string,
@@ -959,10 +976,12 @@ export interface IOrderModuleService extends IModuleService {
   ): Promise<OrderLineItemTaxLineDTO[]>
 
   createLineItemTaxLines(
-    taxLines: CreateOrderLineItemTaxLineDTO[]
+    taxLines: CreateOrderLineItemTaxLineDTO[],
+    sharedContext?: Context
   ): Promise<OrderLineItemTaxLineDTO[]>
   createLineItemTaxLines(
-    taxLine: CreateOrderLineItemTaxLineDTO
+    taxLine: CreateOrderLineItemTaxLineDTO,
+    sharedContext?: Context
   ): Promise<OrderLineItemTaxLineDTO>
   createLineItemTaxLines(
     orderId: string,
@@ -1039,10 +1058,12 @@ export interface IOrderModuleService extends IModuleService {
   ): Promise<OrderShippingMethodTaxLineDTO[]>
 
   createShippingMethodTaxLines(
-    taxLines: CreateOrderShippingMethodTaxLineDTO[]
+    taxLines: CreateOrderShippingMethodTaxLineDTO[],
+    sharedContext?: Context
   ): Promise<OrderShippingMethodTaxLineDTO[]>
   createShippingMethodTaxLines(
-    taxLine: CreateOrderShippingMethodTaxLineDTO
+    taxLine: CreateOrderShippingMethodTaxLineDTO,
+    sharedContext?: Context
   ): Promise<OrderShippingMethodTaxLineDTO>
   createShippingMethodTaxLines(
     orderId: string,
@@ -1257,42 +1278,6 @@ export interface IOrderModuleService extends IModuleService {
     sharedContext?: Context
   ): Promise<void>
 
-  /**
-   * This method deletes order change by its ID.
-   *
-   * @param {string[]} orderChangeId - The list of {summary}
-   * @param {Context} sharedContext - A context used to share resources, such as transaction manager, between the application and the module.
-   * @returns {Promise<void>} Resolves when {summary}
-   *
-   * @example
-   * ```typescript
-   * await orderModuleService.deleteOrderChanges(["orderChangeId1", "orderChangeId2"]);
-   * ```
-   *
-   */
-  deleteOrderChanges(
-    orderChangeId: string[],
-    sharedContext?: Context
-  ): Promise<void>
-
-  /**
-   * This method deletes order change by its ID.
-   *
-   * @param {string} orderChangeId - The order's ID.
-   * @param {Context} sharedContext - A context used to share resources, such as transaction manager, between the application and the module.
-   * @returns {Promise<void>} Resolves when {summary}
-   *
-   * @example
-   * ```typescript
-   * await orderModuleService.deleteOrderChanges("orderChangeId");
-   * ```
-   *
-   */
-  deleteOrderChanges(
-    orderChangeId: string,
-    sharedContext?: Context
-  ): Promise<void>
-
   /**
    * This method Represents the completion of an asynchronous operation
    *
@@ -1402,7 +1387,7 @@ export interface IOrderModuleService extends IModuleService {
   confirmOrderChange(
     orderChangeId: string[],
     sharedContext?: Context
-  ): Promise<void>
+  ): Promise<OrderChangeReturn>
 
   /**
    * This method Represents the completion of an asynchronous operation
@@ -1422,7 +1407,7 @@ export interface IOrderModuleService extends IModuleService {
   confirmOrderChange(
     data: ConfirmOrderChangeDTO,
     sharedContext?: Context
-  ): Promise<void>
+  ): Promise<OrderChangeReturn>
 
   /**
    * This method Represents the completion of an asynchronous operation
@@ -1444,7 +1429,7 @@ export interface IOrderModuleService extends IModuleService {
   confirmOrderChange(
     data: ConfirmOrderChangeDTO[],
     sharedContext?: Context
-  ): Promise<void>
+  ): Promise<OrderChangeReturn>
 
   /**
    * This method Represents the completion of an asynchronous operation
@@ -1863,7 +1848,8 @@ export interface IOrderModuleService extends IModuleService {
   ): Promise<OrderReturnReasonDTO[]>
 
   updateReturnReasons(
-    data: UpdateOrderReturnReasonWithSelectorDTO[]
+    data: UpdateOrderReturnReasonWithSelectorDTO[],
+    sharedContext?: Context
   ): Promise<OrderReturnReasonDTO[]>
   updateReturnReasons(
     selector: Partial<FilterableOrderReturnReasonProps>,
@@ -1913,7 +1899,10 @@ export interface IOrderModuleService extends IModuleService {
     sharedContext?: Context
   ): Promise<ReturnDTO[]>
 
-  updateReturns(data: UpdateOrderReturnWithSelectorDTO[]): Promise<ReturnDTO[]>
+  updateReturns(
+    data: UpdateOrderReturnWithSelectorDTO[],
+    sharedContext?: Context
+  ): Promise<ReturnDTO[]>
 
   updateReturns(
     selector: Partial<FilterableReturnProps>,
@@ -1953,7 +1942,8 @@ export interface IOrderModuleService extends IModuleService {
   ): Promise<OrderClaimDTO[]>
 
   updateOrderClaims(
-    data: UpdateOrderClaimWithSelectorDTO[]
+    data: UpdateOrderClaimWithSelectorDTO[],
+    sharedContext?: Context
   ): Promise<OrderClaimDTO[]>
 
   updateOrderClaims(
@@ -1992,7 +1982,8 @@ export interface IOrderModuleService extends IModuleService {
   ): Promise<OrderExchangeDTO[]>
 
   updateOrderExchanges(
-    data: UpdateOrderExchangeWithSelectorDTO[]
+    data: UpdateOrderExchangeWithSelectorDTO[],
+    sharedContext?: Context
   ): Promise<OrderExchangeDTO[]>
 
   updateOrderExchanges(

packages/modules/order/src/models/order-change.ts

@@ -156,7 +156,7 @@ export default class OrderChange {
   change_type: OrderChangeType | null = null
 
   @OneToMany(() => OrderChangeAction, (action) => action.order_change, {
-    cascade: [Cascade.PERSIST, "sotf-remove" as Cascade],
+    cascade: [Cascade.PERSIST, "soft-remove" as Cascade],
   })
   actions = new Collection<Rel<OrderChangeAction>>(this)