chore: fixes to http and request types for payment and regions (#13831)

packages/core/types/src/http/price-list/admin/payloads.ts

@@ -38,7 +38,7 @@ export interface AdminCreatePriceList {
   /**
    * The price list's description.
    */
-  description?: string | null
+  description: string
   /**
    * The price list's start date.
    */
@@ -50,11 +50,11 @@ export interface AdminCreatePriceList {
   /**
    * The price list's status.
    */
-  status: PriceListStatus
+  status?: PriceListStatus
   /**
    * The price list's type.
    */
-  type: PriceListType
+  type?: PriceListType
   /**
    * The price list's rules.
    */

packages/core/types/src/http/region/store/queries.ts

@@ -1,5 +1,6 @@
+import { FindParams } from "../../common";
 import { BaseRegionCountryFilters, BaseRegionFilters } from "../common"
 
 export interface StoreRegionFilters
-  extends Omit<BaseRegionFilters, "created_at" | "updated_at"> {}
+  extends Omit<BaseRegionFilters, "created_at" | "updated_at">, FindParams {}
 export interface StoreRegionCountryFilters extends BaseRegionCountryFilters {}

packages/medusa/src/api/admin/currencies/[code]/route.ts

@@ -7,7 +7,7 @@ import { MedusaRequest, MedusaResponse } from "@medusajs/framework/http"
 import { HttpTypes } from "@medusajs/framework/types"
 
 export const GET = async (
-  req: MedusaRequest,
+  req: MedusaRequest<HttpTypes.AdminCurrencyParams>,
   res: MedusaResponse<HttpTypes.AdminCurrencyResponse>
 ) => {
   const remoteQuery = req.scope.resolve(ContainerRegistrationKeys.REMOTE_QUERY)

packages/medusa/src/api/admin/price-lists/[id]/products/route.ts

@@ -8,7 +8,10 @@ import {
 import { fetchPriceList, fetchPriceListPriceIdsForProduct } from "../../helpers"
 
 export const POST = async (
-  req: AuthenticatedMedusaRequest<HttpTypes.AdminLinkPriceListProducts>,
+  req: AuthenticatedMedusaRequest<
+    HttpTypes.AdminLinkPriceListProducts,
+    HttpTypes.AdminPriceListParams
+  >,
   res: MedusaResponse<HttpTypes.AdminPriceListResponse>
 ) => {
   const id = req.params.id

packages/medusa/src/api/admin/price-lists/[id]/route.ts

@@ -7,11 +7,10 @@ import {
   MedusaResponse,
 } from "@medusajs/framework/http"
 import { fetchPriceList } from "../helpers"
-import { AdminUpdatePriceListType } from "../validators"
 import { HttpTypes } from "@medusajs/framework/types"
 
 export const GET = async (
-  req: AuthenticatedMedusaRequest,
+  req: AuthenticatedMedusaRequest<HttpTypes.AdminPriceListParams>,
   res: MedusaResponse<HttpTypes.AdminPriceListResponse>
 ) => {
   const price_list = await fetchPriceList(
@@ -24,7 +23,10 @@ export const GET = async (
 }
 
 export const POST = async (
-  req: AuthenticatedMedusaRequest<AdminUpdatePriceListType>,
+  req: AuthenticatedMedusaRequest<
+    HttpTypes.AdminUpdatePriceList,
+    HttpTypes.AdminPriceListParams
+  >,
   res: MedusaResponse<HttpTypes.AdminPriceListResponse>
 ) => {
   const id = req.params.id

packages/medusa/src/api/admin/price-lists/route.ts

@@ -8,7 +8,6 @@ import {
   MedusaResponse,
 } from "@medusajs/framework/http"
 import { fetchPriceList, transformPriceList } from "./helpers"
-import { AdminCreatePriceListType } from "./validators"
 import { HttpTypes } from "@medusajs/framework/types"
 
 export const GET = async (
@@ -37,7 +36,10 @@ export const GET = async (
 }
 
 export const POST = async (
-  req: AuthenticatedMedusaRequest<AdminCreatePriceListType>,
+  req: AuthenticatedMedusaRequest<
+    HttpTypes.AdminCreatePriceList,
+    HttpTypes.AdminPriceListListParams
+  >,
   res: MedusaResponse<HttpTypes.AdminPriceListResponse>
 ) => {
   const workflow = createPriceListsWorkflow(req.scope)

packages/medusa/src/api/admin/price-preferences/[id]/route.ts

@@ -11,7 +11,7 @@ import {
 } from "@medusajs/framework/http"
 
 export const GET = async (
-  req: AuthenticatedMedusaRequest,
+  req: AuthenticatedMedusaRequest<HttpTypes.AdminPricePreferenceParams>,
   res: MedusaResponse<HttpTypes.AdminPricePreferenceResponse>
 ) => {
   const price_preference = await refetchEntity({
@@ -25,7 +25,10 @@ export const GET = async (
 }
 
 export const POST = async (
-  req: AuthenticatedMedusaRequest<HttpTypes.AdminUpdatePricePreference>,
+  req: AuthenticatedMedusaRequest<
+    HttpTypes.AdminUpdatePricePreference,
+    HttpTypes.AdminPricePreferenceParams
+  >,
   res: MedusaResponse<HttpTypes.AdminPricePreferenceResponse>
 ) => {
   const id = req.params.id

packages/medusa/src/api/admin/price-preferences/route.ts

@@ -28,7 +28,10 @@ export const GET = async (
 }
 
 export const POST = async (
-  req: AuthenticatedMedusaRequest<HttpTypes.AdminCreatePricePreference>,
+  req: AuthenticatedMedusaRequest<
+    HttpTypes.AdminCreatePricePreference,
+    HttpTypes.AdminPricePreferenceParams
+  >,
   res: MedusaResponse<HttpTypes.AdminPricePreferenceResponse>
 ) => {
   const workflow = createPricePreferencesWorkflow(req.scope)

packages/medusa/src/api/admin/regions/[id]/route.ts

@@ -8,11 +8,12 @@ import {
   MedusaResponse,
 } from "@medusajs/framework/http"
 import { refetchRegion } from "../helpers"
-import { AdminGetRegionParamsType, AdminUpdateRegionType } from "../validators"
 import { HttpTypes } from "@medusajs/framework/types"
 
 export const GET = async (
-  req: AuthenticatedMedusaRequest<AdminGetRegionParamsType>,
+  req: AuthenticatedMedusaRequest<
+    HttpTypes.SelectParams
+  >,
   res: MedusaResponse<HttpTypes.AdminRegionResponse>
 ) => {
   const region = await refetchRegion(
@@ -32,7 +33,10 @@ export const GET = async (
 }
 
 export const POST = async (
-  req: AuthenticatedMedusaRequest<AdminUpdateRegionType>,
+  req: AuthenticatedMedusaRequest<
+    HttpTypes.AdminUpdateRegion,
+    HttpTypes.SelectParams
+  >,
   res: MedusaResponse<HttpTypes.AdminRegionResponse>
 ) => {
   const existingRegion = await refetchRegion(req.params.id, req.scope, ["id"])

packages/medusa/src/api/admin/regions/route.ts

@@ -36,7 +36,10 @@ export const GET = async (
 }
 
 export const POST = async (
-  req: AuthenticatedMedusaRequest<HttpTypes.AdminCreateRegion>,
+  req: AuthenticatedMedusaRequest<
+    HttpTypes.AdminCreateRegion,
+    HttpTypes.SelectParams
+  >,
   res: MedusaResponse<HttpTypes.AdminRegionResponse>
 ) => {
   const input = [req.validatedBody]

packages/medusa/src/api/store/currencies/[code]/route.ts

@@ -7,7 +7,7 @@ import { MedusaRequest, MedusaResponse } from "@medusajs/framework/http"
 import { HttpTypes } from "@medusajs/framework/types"
 
 export const GET = async (
-  req: MedusaRequest,
+  req: MedusaRequest<HttpTypes.SelectParams>,
   res: MedusaResponse<HttpTypes.StoreCurrencyResponse>
 ) => {
   const remoteQuery = req.scope.resolve(ContainerRegistrationKeys.REMOTE_QUERY)

packages/medusa/src/api/store/regions/[id]/route.ts

@@ -7,7 +7,7 @@ import { MedusaRequest, MedusaResponse } from "@medusajs/framework/http"
 import { HttpTypes } from "@medusajs/framework/types"
 
 export const GET = async (
-  req: MedusaRequest,
+  req: MedusaRequest<HttpTypes.SelectParams>,
   res: MedusaResponse<HttpTypes.StoreRegionResponse>
 ) => {
   const remoteQuery = req.scope.resolve(ContainerRegistrationKeys.REMOTE_QUERY)