fix(product, types): add missing types for variant images and thumbnails (#14026)
## Summary
**What** — What changes are introduced in this PR?
- Add missing `images` field of variants to the HTTP types
- Add missing `thumbnail` field to product variant schema, which leads to the thumbnail missing from auto generated types
**Why** — Why are these changes relevant or necessary?
*Please provide answer here*
**How** — How have these changes been implemented?
*Please provide answer here*
**Testing** — How have these changes been tested, or how can the reviewer test the feature?
*Please provide answer here*
---
## Examples
Provide examples or code snippets that demonstrate how this feature works, or how it can be used in practice.
This helps with documentation and ensures maintainers can quickly understand and verify the change.
```ts
// Example usage
```
---
## Checklist
Please ensure the following before requesting a review:
- [ ] I have added a **changeset** for this PR
- Every non-breaking change should be marked as a **patch**
- To add a changeset, run `yarn changeset` and follow the prompts
- [ ] The changes are covered by relevant **tests**
- [ ] I have verified the code works as intended locally
- [ ] I have linked the related issue(s) if applicable
---
## Additional Context
Add any additional context, related issues, or references that might help the reviewer understand this PR.
This commit is contained in:
6
.changeset/warm-groups-lay.md
Normal file
6
.changeset/warm-groups-lay.md
Normal file
@@ -0,0 +1,6 @@
|
||||
---
|
||||
"@medusajs/product": patch
|
||||
"@medusajs/types": patch
|
||||
---
|
||||
|
||||
fix(product, types): add missing types for variant images and thumbnails
|
||||
@@ -59,11 +59,6 @@ export interface AdminProductVariant extends BaseProductVariant {
|
||||
* The variant's inventory items.
|
||||
*/
|
||||
inventory_items?: AdminProductVariantInventoryItemLink[] | null
|
||||
|
||||
/**
|
||||
* The variant's images.
|
||||
*/
|
||||
images?: AdminProductImage[] | null
|
||||
}
|
||||
export interface AdminProductOption extends BaseProductOption {
|
||||
/**
|
||||
|
||||
@@ -163,6 +163,10 @@ export interface BaseProductVariant {
|
||||
* The variant's thumbnail.
|
||||
*/
|
||||
thumbnail: string | null
|
||||
/**
|
||||
* The variant's images.
|
||||
*/
|
||||
images: BaseProductImage[] | null
|
||||
/**
|
||||
* Whether the variant can be ordered even if it's out of stock.
|
||||
*/
|
||||
|
||||
@@ -60,6 +60,7 @@ type ProductVariant {
|
||||
width: Float
|
||||
options: [ProductOptionValue!]!
|
||||
images: [ProductImage!]!
|
||||
thumbnail: String
|
||||
metadata: JSON
|
||||
product: Product
|
||||
product_id: String
|
||||
|
||||
Reference in New Issue
Block a user