fix: make prices optional param when updating a variant (#2155)

**Why**
- It should be possible to update variant props without having to send the prices array with every update
This commit is contained in:
Sebastian Rindom
2022-09-06 15:49:18 +02:00
committed by GitHub
parent 70139d0bbb
commit af80e0fd2e
3 changed files with 48 additions and 0 deletions

View File

@@ -0,0 +1,5 @@
---
"@medusajs/medusa": patch
---
fix(medusa): make prices optional param when updating a variant

View File

@@ -2374,6 +2374,48 @@ describe("/admin/products", () => {
})
})
describe("POST /admin/products/:id/variants/:id", () => {
beforeEach(async () => {
await adminSeeder(dbConnection)
await simpleProductFactory(dbConnection, {
id: "test-product-to-update",
variants: [
{
id: "test-variant-to-update",
},
],
})
})
afterEach(async () => {
const db = useDb()
await db.teardown()
})
it("successfully updates variant without prices", async () => {
const api = useApi()
const res = await api
.post(
"/admin/products/test-product-to-update/variants/test-variant-to-update",
{
inventory_quantity: 10,
},
{
headers: {
Authorization: "Bearer test_token",
},
}
)
.catch((err) => {
console.log(err)
})
expect(res.status).toEqual(200)
})
})
describe("GET /admin/products/tag-usage", () => {
beforeEach(async () => {
await productSeeder(dbConnection)

View File

@@ -310,6 +310,7 @@ export class AdminPostProductsProductVariantsVariantReq {
metadata?: object
@IsArray()
@IsOptional()
@ValidateNested({ each: true })
@Type(() => ProductVariantPricesUpdateReq)
prices: ProductVariantPricesUpdateReq[]