fix(modules-sdk, orchestration): add missing dependencies + fix default handling in medusa-app & remote query (#4930)

.changeset/big-bats-buy.md

@@ -0,0 +1,6 @@
+---
+"@medusajs/modules-sdk": patch
+"@medusajs/orchestration": patch
+---
+
+fix(modules-sdk, orchestration): add missing dependencies

packages/modules-sdk/package.json

@@ -28,6 +28,8 @@
     "@medusajs/types": "^1.10.2",
     "@medusajs/utils": "^1.9.6",
     "awilix": "^8.0.0",
+    "knex": "2.4.2",
+    "pg": "^8.11.2",
     "resolve-cwd": "^3.0.0"
   },
   "scripts": {

packages/modules-sdk/src/medusa-app.ts

@@ -36,30 +36,26 @@ export type SharedResources = {
   }
 }
 
-export async function MedusaApp(
-  {
-    sharedResourcesConfig,
-    servicesConfig,
-    modulesConfigPath,
-    modulesConfigFileName,
-    modulesConfig,
-    linkModules,
-    remoteFetchData,
-    injectedDependencies,
-  }: {
-    sharedResourcesConfig?: SharedResources
-    loadedModules?: LoadedModule[]
-    servicesConfig?: ModuleJoinerConfig[]
-    modulesConfigPath?: string
-    modulesConfigFileName?: string
-    modulesConfig?: MedusaModuleConfig
-    linkModules?: ModuleJoinerConfig | ModuleJoinerConfig[]
-    remoteFetchData?: RemoteFetchDataCallback
-    injectedDependencies?: any
-  } = {
-    injectedDependencies: {},
-  }
-): Promise<{
+export async function MedusaApp({
+  sharedResourcesConfig,
+  servicesConfig,
+  modulesConfigPath,
+  modulesConfigFileName,
+  modulesConfig,
+  linkModules,
+  remoteFetchData,
+  injectedDependencies = {},
+}: {
+  sharedResourcesConfig?: SharedResources
+  loadedModules?: LoadedModule[]
+  servicesConfig?: ModuleJoinerConfig[]
+  modulesConfigPath?: string
+  modulesConfigFileName?: string
+  modulesConfig?: MedusaModuleConfig
+  linkModules?: ModuleJoinerConfig | ModuleJoinerConfig[]
+  remoteFetchData?: RemoteFetchDataCallback
+  injectedDependencies?: any
+}): Promise<{
   modules: Record<string, LoadedModule | LoadedModule[]>
   link: RemoteLink | undefined
   query: (

packages/modules-sdk/src/remote-query.ts

@@ -16,19 +16,15 @@ export class RemoteQuery {
   private modulesMap: Map<string, LoadedModule> = new Map()
   private customRemoteFetchData?: RemoteFetchDataCallback
 
-  constructor(
-    {
-      modulesLoaded,
-      customRemoteFetchData,
-      servicesConfig,
-    }: {
-      modulesLoaded?: LoadedModule[]
-      customRemoteFetchData?: RemoteFetchDataCallback
-      servicesConfig?: ModuleJoinerConfig[]
-    } = {
-      servicesConfig: [],
-    }
-  ) {
+  constructor({
+    modulesLoaded,
+    customRemoteFetchData,
+    servicesConfig = [],
+  }: {
+    modulesLoaded?: LoadedModule[]
+    customRemoteFetchData?: RemoteFetchDataCallback
+    servicesConfig?: ModuleJoinerConfig[]
+  }) {
     if (!modulesLoaded?.length) {
       modulesLoaded = MedusaModule.getLoadedModules().map(
         (mod) => Object.values(mod)[0]

packages/orchestration/package.json

@@ -17,7 +17,6 @@
   "author": "Medusa",
   "license": "MIT",
   "devDependencies": {
-    "@medusajs/types": "^1.10.2",
     "cross-env": "^5.2.1",
     "jest": "^29.6.3",
     "rimraf": "^5.0.1",
@@ -25,7 +24,9 @@
     "typescript": "^5.1.6"
   },
   "dependencies": {
+    "@medusajs/types": "^1.10.2",
     "@medusajs/utils": "^1.9.6",
+    "awilix": "^8.0.0",
     "graphql": "^16.6.0"
   },
   "scripts": {

yarn.lock

@@ -6518,6 +6518,8 @@ __metadata:
     awilix: ^8.0.0
     cross-env: ^5.2.1
     jest: ^29.6.3
+    knex: 2.4.2
+    pg: ^8.11.2
     resolve-cwd: ^3.0.0
     rimraf: ^5.0.1
     ts-jest: ^29.1.1
@@ -6577,6 +6579,7 @@ __metadata:
   dependencies:
     "@medusajs/types": ^1.10.2
     "@medusajs/utils": ^1.9.6
+    awilix: ^8.0.0
     cross-env: ^5.2.1
     graphql: ^16.6.0
     jest: ^29.6.3