asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(modules-sdk): Add missing paths to require.resolve in load resources (#9608)

Browse Source 
FIXES FRMW-2747

**What**

Add missing `paths` options
This commit is contained in:
Adrien de Peretti
2024-10-16 19:20:56 +02:00
committed by GitHub
parent 68560787e5
commit e911c6aebf
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/core/modules-sdk/src/loaders/__tests__/module-loader.ts
View File

@@ -50,7 +50,7 @@ describe("modules loader", () => {
it("should register the service ", async () => {
const moduleResolutions: Record<string, ModuleResolution> = {
testService: {
resolutionPath: "@modules/default",
resolutionPath: require.resolve("../__mocks__/@modules/default"),
definition: {
key: "testService",
defaultPackage: "testService",
@@ -90,7 +90,7 @@ describe("modules loader", () => {
it("should run the defined loaders and logs the errors if something fails", async () => {
const moduleResolutions: Record<string, ModuleResolution> = {
testService: {
resolutionPath: "@modules/brokenloader",
resolutionPath: require.resolve("../__mocks__/@modules/brokenloader"),
definition: {
key: "testService",
defaultPackage: "testService",
@@ -115,7 +115,7 @@ describe("modules loader", () => {
it("should log the errors if no service is defined", async () => {
const moduleResolutions: Record<string, ModuleResolution> = {
testService: {
resolutionPath: "@modules/no-service",
resolutionPath: require.resolve("../__mocks__/@modules/no-service"),
definition: {
key: "testService",
defaultPackage: "testService",
@@ -142,7 +142,7 @@ describe("modules loader", () => {
it("should throw an error if no service is defined and the module is required", async () => {
const moduleResolutions: Record<string, ModuleResolution> = {
testService: {
resolutionPath: "@modules/no-service",
resolutionPath: require.resolve("../__mocks__/@modules/no-service"),
definition: {
key: "testService",
defaultPackage: "testService",

4
packages/core/modules-sdk/src/loaders/utils/load-internal.ts
View File

@@ -542,7 +542,9 @@ export async function loadResources({
loadedModuleLoaders ??= []
const modulePath = discoveryPath
let normalizedPath = dirname(require.resolve(modulePath))
let normalizedPath = dirname(
require.resolve(modulePath, { paths: [process.cwd()] })
)
normalizedPath = resolve(normalizedPath)
try {