asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(search): add missing default product relations (#4008)

Browse Source 
* fix(search): add missing default product relations

Add missing default product relations for events calling SearchService.addDocuments

For the following events: `ProductService.Events.UPDATED,  ProductVariantService.Events.CREATED, ProductVariantService.Events.UPDATED]`,
`SearchService.addDocuments` will fail due to `product` missing its `variants` relations.

The issue can be observed with the Algolia plugin where `reduce` is being attempted on `product.variants`.
https://github.com/medusajs/medusa/blob/develop/packages/medusa-plugin-algolia/src/utils/transformer.ts#L14

Implement the same retrieve pattern as `handleProductCreation` method.

* chore(changeset): patch

---------

Co-authored-by: Oliver Windall Juhl <59018053+olivermrbl@users.noreply.github.com>
This commit is contained in:
patpich
2023-05-05 07:04:56 -04:00
committed by GitHub
parent bd53adb238
commit ff37cd190f
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/warm-ways-leave.md Normal file
View File

@@ -0,0 +1,5 @@
---
"@medusajs/medusa": patch
---
fix(search): add missing default product relations

8
packages/medusa/src/subscribers/product.ts
View File

@@ -62,7 +62,9 @@ class ProductSearchSubscriber {
}
handleProductUpdate = async (data) => {
const product = await this.productService_.retrieve(data.id)
const product = await this.productService_.retrieve(data.id, {
relations: defaultSearchIndexingProductRelations,
})
await this.searchService_.addDocuments(
ProductService.IndexName,
[product],
@@ -75,7 +77,9 @@ class ProductSearchSubscriber {
}
handleProductVariantChange = async (data) => {
const product = await this.productService_.retrieve(data.product_id)
const product = await this.productService_.retrieve(data.product_id, {
relations: defaultSearchIndexingProductRelations,
})
await this.searchService_.addDocuments(
ProductService.IndexName,
[product],