3 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Patrick	1dc816039c	chore(oas): explicitly declare type:object on schemas with properties (#2712) ... ### What OAS: Explicitly declare type:object on schemas with properties. ### Why While not officially required, schemas with properties should have their type explicitly declared as "object". Omitting the type translates to type: any with properties XYZ. The ambiguity can lead to issues when using code generators. ### How Multiple regex searches to identify schemas missing type: object. Manually edit each schema. Spot check generated OAS. ### Testing - Ran OAS validator. - Ran docs build script ### Proof  RESOLVES CORE-847	2022-12-02 13:51:16 +00:00
3 people	022a84691e	fix(draft-order): create tax-inclusive with discount (#2579) ... **What** Fix system error (500) with DraftOrder create operation when payload includes discount in a tax-inclusive context. **How** * Ensure newly created cart contains all required relation in order to calculate line item tax-inclusive pricing with discounts. * Add resilience to TotalsService.getLineDiscounts() * Ensure newly generate line items have variant relation loaded. * fix TotalsService.getLineItemTotals to use the passed lineItem instead of relying on cartOrOrder.items. **Test** * Unit: * TotalsService.getLineDiscounts - coverage * Integration: * Admin API draft-order - coverage * Admin API draft-order create w/ discount in tax-inclusive Resolves: CORE-771 Co-authored-by: Oliver Windall Juhl <59018053+olivermrbl@users.noreply.github.com> Co-authored-by: Adrien de Peretti <25098370+adrien2p@users.noreply.github.com>	2022-11-16 15:34:18 +00:00
Patrick	7b0ceeffb4	feat: /store api product types (#2552) ... ## What Allow users to fetch ProductTypes from the storefront API. ## Why This endpoint will allow developers to implement better faceted product search in Medusa without the need for search plugin. Developers will be able to use this to render refinement lists based on types, like this:  ## How Endpoint `GET /store/products/types` and `GET /store/product-types` (use [product types listing in admin](https://github.com/medusajs/medusa/blob/master/packages/medusa/src/api/routes/admin/products/list-types.ts) as reference) Support added in @medusajs/medusa-js Support added in medusa-react ## Testing Similar automated tests as `GET /admin/products/types` and `GET /admin/product-types` --- Resolves CORE-699	2022-11-09 16:10:17 +00:00