6 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Riqwan Thamir	7fcf2b86a9	chore: prevent adminSession variable from being mutated in the helpers	2022-12-07 16:42:32 +01:00
Riqwan Thamir	66bec2f54d	test: add a case when regions only contain invalid region Ids	2022-12-07 16:42:32 +01:00
Riqwan Thamir	bcc1edbf2b	chore: addressing review - move repeated strings and objects to constants	2022-12-07 16:42:32 +01:00
Riqwan Thamir	cb2a32a82b	chore: add changeset	2022-12-07 16:42:32 +01:00
Riqwan Thamir	f22e063ed8	test: fix existing integration tests and add a new test that validates regions inclusion and validity	2022-12-07 16:42:32 +01:00
Riqwan Thamir	d4e565b0b9	fix: regions are changed from an optional to required field ... A discount should always be associated to atleast 1 region - we validate it against the region in the cart service. Adding a request parameter validation to pass in atleast one regionID in an array of regions will ensure that regionID will be validated as a part of the discount service and fail if its not a valid region ID.	2022-12-07 16:42:32 +01:00