refactor

scripts/SettingsManager.gd

@@ -1,5 +1,6 @@
 extends Node
 
+const LANGUAGES_JSON_PATH := "res://localization/languages.json"
 const SETTINGS_FILE = "user://settings.cfg"
 # dev `user://`=`%APPDATA%\Godot\app_userdata\Skelly`
 # prod `user://`=`%APPDATA%\Skelly\`
@@ -48,21 +49,36 @@ func get_setting(key: String):
 
 func set_setting(key: String, value):
 	settings[key] = value
+	_apply_setting_side_effect(key, value)
+
+func _apply_setting_side_effect(key: String, value) -> void:
+	match key:
+		"language":
+			TranslationServer.set_locale(value)
+		"master_volume":
+			AudioServer.set_bus_volume_db(AudioServer.get_bus_index("Master"), linear_to_db(value))
+		"music_volume":
+			AudioManager.update_music_volume(value)
+		"sfx_volume":
+			AudioServer.set_bus_volume_db(AudioServer.get_bus_index("SFX"), linear_to_db(value))
 
 func load_languages():
-	var file = FileAccess.open("res://localization/languages.json", FileAccess.READ)
-	if file:
-		var json_string = file.get_as_text()
-		file.close()
-		var json = JSON.new()
-		var parse_result = json.parse(json_string)
-		if parse_result == OK:
-			languages_data = json.data
-			print("Languages loaded: ", languages_data.languages.keys())
-		else:
-			print("Error parsing languages.json")
-	else:
+	var file = FileAccess.open(LANGUAGES_JSON_PATH, FileAccess.READ)
+	if not file:
 		print("Could not open languages.json")
+		return
+
+	var json_string = file.get_as_text()
+	file.close()
+
+	var json = JSON.new()
+	if json.parse(json_string) != OK:
+		print("Error parsing languages.json")
+		return
+
+	languages_data = json.data
+	if languages_data.has("languages"):
+		print("Languages loaded: ", languages_data.languages.keys())
 
 func get_languages_data():
 	return languages_data