asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(medusa-file-minio): Minio private bucket default (#4540)

Browse Source 
* default "getUploadDescriptor" to private (similar to aws + digital ocean)

* add changeset
This commit is contained in:
Philip Korsholm
2023-07-17 10:50:06 +02:00
committed by GitHub
parent 4e2e58881a
commit 950a581690
2 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/rotten-peas-heal.md Normal file
View File

@@ -0,0 +1,5 @@
---
"medusa-file-minio": patch
---
fix(medusa-file-minio): default getUploadDescriptor to private

13
packages/medusa-file-minio/src/services/minio.ts
View File

@@ -1,7 +1,3 @@
import stream from "stream"
import aws from "aws-sdk"
import { parse } from "path"
import fs from "fs"
import {
AbstractFileService,
DeleteFileType,
@@ -10,9 +6,14 @@ import {
IFileService,
UploadStreamDescriptorType,
} from "@medusajs/medusa"
import { MedusaError } from "medusa-core-utils"
import { ClientConfiguration, PutObjectRequest } from "aws-sdk/clients/s3"
import { MedusaError } from "medusa-core-utils"
import aws from "aws-sdk"
import fs from "fs"
import { parse } from "path"
import stream from "stream"
class MinioService extends AbstractFileService implements IFileService {
protected bucket_: string
protected accessKeyId_: string
@@ -123,7 +124,7 @@ class MinioService extends AbstractFileService implements IFileService {
contentType?: string
}
) {
const usePrivateBucket = !!fileData.usePrivateBucket
const usePrivateBucket = fileData.usePrivateBucket ?? true
this.validatePrivateBucketConfiguration_(usePrivateBucket)